[CI] x-pack/heartbeat monorepo #38845

pazone · 2024-04-10T22:24:19Z

Proposed commit message

Use mono repo plugin for xpack/heartbeat

Related issues

https://github.com/elastic/ingest-dev/issues/3072

Screenshots

Logs

default labels

main pipeline: https://buildkite.com/elastic/beats/builds/5904
x-pack/heartbeat: https://buildkite.com/elastic/beats-xpack-heartbeat/builds/1786

latest run, after merging conflicts: https://buildkite.com/elastic/beats/builds/5957

macos label

main pipeline: https://buildkite.com/elastic/beats/builds/5937 (heartbeat extended test failures for macos/win2019 are unrelated and will be fixed in a follow up PR, and filebeat macos x86_64 failure was a flaky transient issue)
x-pack/heartbeat: https://buildkite.com/elastic/beats-xpack-heartbeat/builds/1789

mergify · 2024-04-10T22:24:56Z

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @pazone? 🙏.
For such, you'll need to label your PR with:

The upcoming major version of the Elastic Stack
The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

elasticmachine · 2024-04-10T22:38:32Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2024-04-18T09:07:24.601+0000
Duration: 13 min 8 sec

Test stats 🧪

Test	Results
Failed	0
Passed	3
Skipped	0
Total	3

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

dliappis

Thanks for raising this!

Left a few asks for fixes, mostly related to findings/bugs discovered in the last 24hrs.

.buildkite/pipeline.yml

.buildkite/x-pack/pipeline.xpack.heartbeat.yml

.buildkite/pipeline.yml

mergify · 2024-04-15T09:26:35Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b ci_xpack_heartbeat_monorepo upstream/ci_xpack_heartbeat_monorepo
git merge upstream/main
git push upstream ci_xpack_heartbeat_monorepo

sharbuz · 2024-04-15T14:26:28Z

Hi @pazone , please pay attention to this PR, it looks like there are missed some changes related to NodeJS in the .buildkite/scripts/install_tools.sh and .buildkite/scripts/common.sh files

dliappis · 2024-04-15T15:23:14Z

Hi @pazone , please pay attention to this PR, it looks like there are missed some changes related to NodeJS in the .buildkite/scripts/install_tools.sh and .buildkite/scripts/common.sh files

Great comment @sharbuz !

After looking at the scripts you mentioned I think we can skip referencing any of them if:

the pipeline defines ASDF_NODEJS_VERSION: 18.17.1 in the env: section.
This will automatically enable the right node version due to the global pre-command hook.
The apt packages are already pre-installed on the base Ubuntu images

We still need to install the elastic/synthetics node package, as shown in https://github.com/elastic/beats/blob/main/.buildkite/scripts/install_tools.sh#L50-L51, but I think it can simply be explicitly added within the command section like:

echo "Install @elastic/synthetics"
npm i -g @elastic/synthetics

before the last list that runs mage.

Do you remember which step(s) need this node package?

In preparation for the migration to a static pipeline (elastic#38845), this commit removes the Buildkite PR Bot trigger for the pipeline.

In preparation for the migration to a static pipeline (#38845), this commit removes the Buildkite PR Bot trigger for the pipeline.

dliappis · 2024-04-18T06:28:02Z

/test

mergify · 2024-04-18T08:58:31Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b ci_xpack_heartbeat_monorepo upstream/ci_xpack_heartbeat_monorepo
git merge upstream/main
git push upstream ci_xpack_heartbeat_monorepo

dliappis

LGTM based on build status (see issue description links)

Use mono repo plugin for xpack/heartbeat Relates: https://github.com/elastic/ingest-dev/issues/3072 --------- Co-authored-by: Dimitrios Liappis <[email protected]> (cherry picked from commit 0d3a8b6) # Conflicts: # .buildkite/scripts/common.sh # .buildkite/scripts/setenv.sh # .buildkite/x-pack/pipeline.xpack.heartbeat.yml

Use mono repo plugin for xpack/heartbeat Relates: https://github.com/elastic/ingest-dev/issues/3072 --------- Co-authored-by: Dimitrios Liappis <[email protected]> (cherry picked from commit 0d3a8b6) # Conflicts: # .buildkite/scripts/common.sh # .buildkite/scripts/setenv.sh

Use mono repo plugin for xpack/heartbeat Relates: https://github.com/elastic/ingest-dev/issues/3072 (cherry picked from commit 0d3a8b6) --------- Co-authored-by: Pavel Zorin <[email protected]> Co-authored-by: Dimitrios Liappis <[email protected]>

* [CI] x-pack/heartbeat monorepo (#38845) Use mono repo plugin for xpack/heartbeat Relates: https://github.com/elastic/ingest-dev/issues/3072 (cherry picked from commit 0d3a8b6) --------- Co-authored-by: Pavel Zorin <[email protected]> Co-authored-by: Dimitrios Liappis <[email protected]>

[CI] x-pack/heartbeat monorepo

21ebdae

pazone added the enhancement label Apr 10, 2024

botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 10, 2024

mergify bot assigned pazone Apr 10, 2024

notification

22aeeed

merged

5094cd6

pazone marked this pull request as ready for review April 11, 2024 09:33

pazone requested a review from a team as a code owner April 11, 2024 09:33

dliappis requested changes Apr 12, 2024

View reviewed changes

dliappis added a commit to dliappis/beats that referenced this pull request Apr 17, 2024

Remove BK PR Bot trigger for x-pack/heartbeat

615b08a

In preparation for the migration to a static pipeline (elastic#38845), this commit removes the Buildkite PR Bot trigger for the pipeline.

dliappis mentioned this pull request Apr 17, 2024

Remove BK PR Bot trigger for x-pack/heartbeat #39014

Merged

dliappis added the Team:Ingest-EngProd label Apr 17, 2024

botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Apr 17, 2024

dliappis added ci needs_team Indicates that the issue/PR needs a Team:* label labels Apr 17, 2024

botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Apr 17, 2024

dliappis added needs_team Indicates that the issue/PR needs a Team:* label and removed enhancement labels Apr 17, 2024

botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Apr 17, 2024

dliappis added the enhancement label Apr 17, 2024

dliappis added a commit that referenced this pull request Apr 17, 2024

Remove BK PR Bot trigger for x-pack/heartbeat (#39014)

4a5d333

In preparation for the migration to a static pipeline (#38845), this commit removes the Buildkite PR Bot trigger for the pipeline.

dliappis added 4 commits April 17, 2024 17:59

Merge branch 'main' into ci_xpack_heartbeat_monorepo

80c4957

Merge branch 'main' into ci_xpack_heartbeat_monorepo

8c55648

fix trigger

ebdcb4d

pipeline and script fixes

bbb1c92

dliappis force-pushed the ci_xpack_heartbeat_monorepo branch from 2a0f9c6 to ab4fd31 Compare April 17, 2024 16:09

dliappis added macOS Enable builds in the CI for darwin testing :Windows labels Apr 18, 2024

add nodejs on macos

8fdec96

dliappis force-pushed the ci_xpack_heartbeat_monorepo branch from 00e75cf to 8fdec96 Compare April 18, 2024 08:08

unfold ulimit in bk output

c18fa18

Merge branch 'main' into ci_xpack_heartbeat_monorepo

411b2fb

dliappis removed :Windows macOS Enable builds in the CI for darwin testing labels Apr 18, 2024

dliappis self-requested a review April 18, 2024 09:48

dliappis approved these changes Apr 18, 2024

View reviewed changes

dliappis merged commit 0d3a8b6 into main Apr 18, 2024
69 of 79 checks passed

dliappis deleted the ci_xpack_heartbeat_monorepo branch April 18, 2024 09:53

dliappis added backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.13.0 Automated backport with mergify backport-v8.14.0 Automated backport with mergify labels Apr 18, 2024

This was referenced Apr 18, 2024

[7.17](backport #38845) [CI] x-pack/heartbeat monorepo #39039

Merged

[8.13](backport #38845) [CI] x-pack/heartbeat monorepo #39040

Merged

[8.14](backport #38845) [CI] x-pack/heartbeat monorepo #39041

Merged

dliappis added a commit to dliappis/beats that referenced this pull request Apr 18, 2024

Fix conflict issues after merging elastic#38845

94c837e

dliappis mentioned this pull request Apr 18, 2024

Fix conflict issues after merging #38845 #39042

Merged

dliappis added a commit that referenced this pull request Apr 18, 2024

Fix conflict issues after merging #38845 (#39042)

397aba0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CI] x-pack/heartbeat monorepo #38845

[CI] x-pack/heartbeat monorepo #38845

pazone commented Apr 10, 2024 •

edited by dliappis

Loading

mergify bot commented Apr 10, 2024

elasticmachine commented Apr 10, 2024 •

edited

Loading

Build stats

Test stats 🧪

dliappis left a comment

mergify bot commented Apr 15, 2024

sharbuz commented Apr 15, 2024

dliappis commented Apr 15, 2024 •

edited

Loading

dliappis commented Apr 18, 2024

mergify bot commented Apr 18, 2024

dliappis left a comment

[CI] x-pack/heartbeat monorepo #38845

[CI] x-pack/heartbeat monorepo #38845

Conversation

pazone commented Apr 10, 2024 • edited by dliappis Loading

Proposed commit message

Related issues

Screenshots

Logs

default labels

macos label

mergify bot commented Apr 10, 2024

elasticmachine commented Apr 10, 2024 • edited Loading

💚 Build Succeeded

Build stats

Test stats 🧪

💚 Flaky test report

🤖 GitHub comments

dliappis left a comment

Choose a reason for hiding this comment

mergify bot commented Apr 15, 2024

sharbuz commented Apr 15, 2024

dliappis commented Apr 15, 2024 • edited Loading

dliappis commented Apr 18, 2024

mergify bot commented Apr 18, 2024

dliappis left a comment

Choose a reason for hiding this comment

pazone commented Apr 10, 2024 •

edited by dliappis

Loading

elasticmachine commented Apr 10, 2024 •

edited

Loading

dliappis commented Apr 15, 2024 •

edited

Loading